Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cam6_3_111: create CAM LT and MT 1850 use_cases #806

Merged
merged 10 commits into from
May 17, 2023

Conversation

cacraigucar
Copy link
Collaborator

Closes #804

@cacraigucar cacraigucar self-assigned this May 11, 2023
@cacraigucar cacraigucar marked this pull request as draft May 11, 2023 22:12
@cecilehannay
Copy link
Collaborator

We want the same changes in hist_lt.xml and hist_mt.xml

@cacraigucar cacraigucar marked this pull request as ready for review May 12, 2023 21:04
@cacraigucar cacraigucar changed the title create CAM LT and MT 1850 use_cases cam6_3_111: create CAM LT and MT 1850 use_cases May 15, 2023
fvitt and others added 2 commits May 16, 2023 10:24
…ts for testing

        modified:   bld/build-namelist
        modified:   bld/namelist_files/namelist_defaults_cam.xml
        modified:   bld/namelist_files/use_cases/1850_cam_lt.xml
        modified:   bld/namelist_files/use_cases/1850_cam_mt.xml
        modified:   bld/namelist_files/use_cases/hist_cam_lt.xml
        modified:   bld/namelist_files/use_cases/hist_cam_mt.xml
        modified:   cime_config/config_compsets.xml
@nusbaume nusbaume self-requested a review May 17, 2023 17:02
Copy link
Collaborator

@nusbaume nusbaume left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just added a couple reminders about updating the ChangeLog before merging.


Purpose of changes (include the issue number and title text for each relevant GitHub issue):
- Add use_cases for 1850 LT and MT compsets: https://github.com/ESCOMP/CAM/issues/804
IMPORTANT NOTE -- LT compsets do not restart
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a reminder to remove or modify this line if LT compsets do restart successfully for Cecile.

doc/ChangeLog Outdated
Comment on lines 46 to 50
????????????????????????????????????DO WE WANT TO KEEP TEMPORARILY??????????????????????????????????
????????????????????????????????????DO WE WANT TO KEEP TEMPORARILY??????????????????????????????????
????????????????????????????????????DO WE WANT TO KEEP TEMPORARILY??????????????????????????????????
????????????????????????????????????DO WE WANT TO KEEP TEMPORARILY??????????????????????????????????
????????????????????????????????????DO WE WANT TO KEEP TEMPORARILY??????????????????????????????????
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just adding a reminder to "answer" this question in the ChangeLog before merging.

@cacraigucar cacraigucar merged commit 379603b into ESCOMP:cam_development May 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Tag
Development

Successfully merging this pull request may close these issues.

4 participants